[HttpClient] added CachingHttpClient #30629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
requested changes
Mar 22, 2019
|
|
||
| $request = Request::create($url, $method); | ||
| $request->attributes->set('http_client_options', $options); | ||
| $request->headers->add($options['headers']); |
Member
There was a problem hiding this comment.
You also need to add support for Cookies.
nicolas-grekas
force-pushed
the
hc-caching
branch
4 times, most recently
from
9981b83 to
f6e4411
Compare
nicolas-grekas
force-pushed
the
hc-caching
branch
from
f6e4411 to
dae5686
Compare
fabpot
approved these changes
Mar 23, 2019
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Mar 23, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [HttpClient] added CachingHttpClient | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The proposed `CachingHttpClient` uses `HttpCache` from the HttpKernel component to provide an HTTP-compliant cache. If this is accepted, it could replace the corresponding part in #30602 Commits ------- dae5686 [HttpClient] added CachingHttpClient
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposed
CachingHttpClientusesHttpCachefrom the HttpKernel component to provide an HTTP-compliant cache.If this is accepted, it could replace the corresponding part in #30602