[TwigBridge] Fix DebugCommand when chain loader is involved #30440
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
commented
Mar 4, 2019
ro0NL
reviewed
Mar 4, 2019
fabpot
approved these changes
Mar 20, 2019
Member
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Mar 20, 2019
…d (yceruto) This PR was merged into the 4.2 branch. Discussion ---------- [TwigBridge] Fix DebugCommand when chain loader is involved | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #30426 | License | MIT Better diff: https://github.com/symfony/symfony/pull/30440/files?utf8=%E2%9C%93&diff=unified&w=1 Commits ------- f647b4a Fix DebugCommand when chain loader is involved
stof
reviewed
Mar 20, 2019
fabpot
added a commit
that referenced
this pull request
Mar 20, 2019
… same namespace (yceruto) This PR was merged into the 4.2 branch. Discussion ---------- Fix case when multiple loaders are providing paths for the same namespace | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT Fixes @stof #30440 (comment) Let me know if a test case is necessary for this. Cheers! Commits ------- 393d728 Fix case when multiple loaders are providing paths for the same namespace
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better diff: https://github.com/symfony/symfony/pull/30440/files?utf8=%E2%9C%93&diff=unified&w=1