Skip to content

Conversation

@shyim
Copy link
Contributor

@shyim shyim commented Feb 26, 2019

Q A
Branch? 4.2
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #..
License MIT
Doc PR

There are some git diff marker :)

@xabbuh
Copy link
Member

xabbuh commented Feb 26, 2019

Good catch. 👍 Can you also remove the accidentally added setTrustedHeaderName() and getTrustedHeaderName() methods and rebase on the 4.2 branch?

@shyim shyim changed the base branch from master to 4.2 February 26, 2019 08:04
@shyim
Copy link
Contributor Author

shyim commented Feb 26, 2019

Done :)

@nicolas-grekas
Copy link
Member

Thank you @shyim.

@nicolas-grekas nicolas-grekas merged commit d631bd9 into symfony:4.2 Feb 26, 2019
nicolas-grekas added a commit that referenced this pull request Feb 26, 2019
This PR was merged into the 4.2 branch.

Discussion
----------

Fix git diff marker

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #..
| License       | MIT
| Doc PR        |

There are some git diff marker :)

Commits
-------

d631bd9 Fix git diff marker
@shyim shyim deleted the fix-conflict branch February 26, 2019 08:46
@xabbuh
Copy link
Member

xabbuh commented Feb 26, 2019

Congratulations for you first contribution @shyim!

@shyim
Copy link
Contributor Author

shyim commented Feb 26, 2019

It should be the second one 🤔
#28820 😅 but ty 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants