[VarDumper] fix dumping Ds maps and pairs #30349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
vd-nohandle
branch
2 times, most recently
from
cf1641e to
ee20ef6
Compare
enumag
reviewed
Feb 22, 2019
nicolas-grekas
force-pushed
the
vd-nohandle
branch
from
ee20ef6 to
da24013
Compare
nicolas-grekas
force-pushed
the
vd-nohandle
branch
from
da24013 to
45869ac
Compare
enumag
approved these changes
Feb 22, 2019
Contributor
|
Thanks for this @nicolas-grekas! |
fabpot
approved these changes
Feb 23, 2019
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Feb 23, 2019
This PR was merged into the 4.3-dev branch. Discussion ---------- [VarDumper] fix dumping Ds maps and pairs | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Fixes #30311 (comment)  Commits ------- 45869ac [VarDumper] fix dumping Ds maps and pairs
Contributor
|
Thank you @nicolas-grekas! I can confirm this fixes the original problem we had as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #30311 (comment)