Skip to content

Disable Twig in the profiler menu when Twig is not used #30037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Jan 30, 2019
Merged

Disable Twig in the profiler menu when Twig is not used #30037

nicolas-grekas merged 1 commit into from
Jan 30, 2019

Conversation

@javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz commented Jan 30, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #30033
License MIT
Doc PR -

@javiereguiluz javiereguiluz added this to the 3.4 milestone Jan 30, 2019
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jan 30, 2019

Thank you @javiereguiluz.

@nicolas-grekas nicolas-grekas merged commit b474081 into symfony:3.4 Jan 30, 2019
nicolas-grekas added a commit that referenced this pull request Jan 30, 2019
@nicolas-grekas
bug #30037 Disable Twig in the profiler menu when Twig is not used (j…
fb43484 
…aviereguiluz)

This PR was merged into the 3.4 branch.

Discussion
----------

Disable Twig in the profiler menu when Twig is not used

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #30033
| License       | MIT
| Doc PR        | -

Commits
-------

b474081 Disable Twig in the profiler menu when Twig is not used
This was referenced Feb 3, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xabbuh xabbuh xabbuh approved these changes

Assignees

No one assigned

Labels

Bug Status: Reviewed WebProfilerBundle

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

4 participants

@javiereguiluz @nicolas-grekas @xabbuh @carsonbot