[DebugClassLoader] expose proxyfied findFile() method #29833
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It could be considered as a bug fix as well. |
Member
|
Is it common to use DebugClassLoader within Drupal? |
Contributor
Author
I don't know. I want to use it. A lot of people might currently use it and have not detected this problem because the incriminated class ( But I don't want this PR to be treated as a request for Drupal. I will report the bad implementation to Drupal issues. It just gonna take forever before getting fixed. The Debug component is here for a better DX. So it just seems logical to try our best in the WDYT of my proposition to try to proxify every wrapped class loader methods ? |
fancyweb
force-pushed
the
readd-find-file-in-debug-class-loader
branch
from
32cfe3f to
547b762
Compare
nicolas-grekas
approved these changes
Jan 11, 2019
nicolas-grekas
changed the title
fabpot
force-pushed
the
readd-find-file-in-debug-class-loader
branch
from
547b762 to
4f690a3
Compare
Member
|
Thank you @fancyweb. |
fabpot
added a commit
that referenced
this pull request
Jan 13, 2019
…cyweb) This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #29833). Discussion ---------- [DebugClassLoader] expose proxyfied findFile() method | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - As bad as it is, some third party libraries expect that at least one autoload function will be the Composer one and have behaviors that relies on the public `findFile` method. When the `DebugClassLoader` wraps the Composer `ClassLoader`, the function `findFile` is currently lost. So it becomes impossible to use the `DebugClassLoader` with these libraries. This is for example the case in Drupal 😢 (cf https://github.com/drupal/core/blob/83bc30ac4030ed163e1919ca5e12b338a22c87dd/lib/Drupal/Component/ClassFinder/ClassFinder.php). Fixing these bad implementations in third party libraries can take forever as things move way slower than in Symfony. This is why I think supporting this case directly in Symfony is better. It's easy and will make the `DebugClassLoader` compatible with more cases. What could be done to go further in this direction would be to proxify any method implementend by wrapped class loaders. Commits ------- 4f690a3 [DebugClassLoader] Readd findFile() method
This was referenced Jan 29, 2019
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As bad as it is, some third party libraries expect that at least one autoload function will be the Composer one and have behaviors that relies on the public
findFilemethod.When the
DebugClassLoaderwraps the ComposerClassLoader, the functionfindFileis currently lost. So it becomes impossible to use theDebugClassLoaderwith these libraries.This is for example the case in Drupal 😢 (cf https://github.com/drupal/core/blob/83bc30ac4030ed163e1919ca5e12b338a22c87dd/lib/Drupal/Component/ClassFinder/ClassFinder.php).
Fixing these bad implementations in third party libraries can take forever as things move way slower than in Symfony. This is why I think supporting this case directly in Symfony is better. It's easy and will make the
DebugClassLoadercompatible with more cases.What could be done to go further in this direction would be to proxify any method implementend by wrapped class loaders.