[TwigBridge][Form] Prevent multiple rendering of form collection prototypes #29527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
approved these changes
Dec 8, 2018
Member
|
Please update the PR + commit titles to a standalone self-describing and short one. Please also add the target component in square brackets. |
Shoplifter
changed the title
Shoplifter
changed the title
HeahDude
approved these changes
Dec 12, 2018
Member
|
Thank you @Shoplifter. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 12, 2018
…ection prototypes (Shoplifter) This PR was merged into the 3.4 branch. Discussion ---------- [TwigBridge][Form] Prevent multiple rendering of form collection prototypes | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #29489 <!-- #-prefixed issue number(s), if any --> | License | MIT prevents attemt to render of prototype in CollectionType when it has been rendered already. (see [Deprecated calling FormRenderer::searchAndRenderBlock for fields which were already rendered.](https://github.com/symfony/symfony/blob/master/UPGRADE-4.2.md#form)) Commits ------- ffd2722 [TwigBridge][Form] Prevent multiple rendering of form collection prototypes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevents attemt to render of prototype in CollectionType when it has been rendered already.
(see Deprecated calling FormRenderer::searchAndRenderBlock for fields which were already rendered.)