[TwigBridge] Deprecating legacy Twig paths in DebugCommand and simplifications #29481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
force-pushed
the
twig_debug_command
branch
3 times, most recently
from
1f7c843 to
1c22633
Compare
Member
Author
|
(Travis failure unrelated) |
xabbuh
reviewed
Dec 6, 2018
| $path = $relativePath.$name; | ||
| $carry[$name] = $path; | ||
| } | ||
| $relativePath = ltrim(substr($this->rootDir.\DIRECTORY_SEPARATOR.'Resources/', \strlen($this->projectDir)), \DIRECTORY_SEPARATOR); |
Member
There was a problem hiding this comment.
Should we use getRelativePath() here too?
xabbuh
approved these changes
Dec 6, 2018
nicolas-grekas
force-pushed
the
twig_debug_command
branch
from
1c22633 to
96169b8
Compare
Member
|
Thank you @yceruto. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 6, 2018
… and simplifications (yceruto) This PR was squashed before being merged into the 4.2 branch (closes #29481). Discussion ---------- [TwigBridge] Deprecating legacy Twig paths in DebugCommand and simplifications | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I've also added some missing tests. Commits ------- 96169b8 [TwigBridge] Deprecating legacy Twig paths in DebugCommand and simplifications
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also added some missing tests.