[DI] Fix dumping expressions accessing single-use private services #29414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
force-pushed
the
expr-inline-call
branch
2 times, most recently
from
bda7e66 to
3f2be01
Compare
Member
|
I changed L602 recently and I think it should be reverted as it's a very local workaround. Can you have a look please? |
chalasr
force-pushed
the
expr-inline-call
branch
from
3f2be01 to
0d12d93
Compare
Member
Author
|
@nicolas-grekas done |
chalasr
force-pushed
the
expr-inline-call
branch
from
0d12d93 to
e05f8c0
Compare
nicolas-grekas
approved these changes
Dec 1, 2018
nicolas-grekas
force-pushed
the
expr-inline-call
branch
from
e05f8c0 to
d1e84aa
Compare
Member
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 2, 2018
…services (chalasr) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Fix dumping expressions accessing single-use private services | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29403 | License | MIT | Doc PR | n/a Introduced in #27268, see fixed ticket Commits ------- d1e84aa [DI] Fix dumping expressions accessing single-use private services
This was referenced Dec 6, 2018
Merged
Closed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #27268, see fixed ticket