[Routing] fix greediness of trailing slash #29380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 30, 2018
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 4.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #29363 |
| License | MIT |
| Doc PR | - |
Contributor
|
To me all these bugs and ugly workarounds show that #29297 should not have been done. |
nicolas-grekas
force-pushed
the
route-greedy-slash
branch
2 times, most recently
from
f58ead5 to
6f1e4f2
Compare
nicolas-grekas
force-pushed
the
route-greedy-slash
branch
from
6f1e4f2 to
eb6aee6
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Nov 30, 2018
This PR was merged into the 4.1 branch. Discussion ---------- [Routing] fix greediness of trailing slash | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29363 | License | MIT | Doc PR | - Commits ------- eb6aee6 [Routing] fix greediness of trailing slash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.