[PropertyAccess] make cache keys encoding bijective #29332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 26, 2018
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #29329 (comment) |
| License | MIT |
| Doc PR | - |
nicolas-grekas
changed the title
fabpot
approved these changes
Nov 26, 2018
Member
fabpot
left a comment
fabpot
left a comment
There was a problem hiding this comment.
A little unit test would be great :)
nicolas-grekas
force-pushed
the
pa-enc
branch
from
ff3d714 to
4fe566b
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Nov 26, 2018
…as-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [PropertyAccess] make cache keys encoding bijective | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29329 (comment) | License | MIT | Doc PR | - Commits ------- 4fe566b [PropertyAccess] make cache keys encoding bijective
This was referenced Nov 26, 2018
Merged
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.