[WebProfiler] Detect non-file paths in file viewer #29317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
changed the title
maxhelias
approved these changes
Nov 25, 2018
Member
|
Looks like a bug to me. Is it something we can merge in older branches? |
Contributor
Author
|
Done. |
fabpot
approved these changes
Nov 26, 2018
Member
|
Thank you @ro0NL. |
fabpot
added a commit
that referenced
this pull request
Nov 26, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [WebProfiler] Detect non-file paths in file viewer | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> We actually link directories sometimes :) now looks like:  Commits ------- 71aade3 [WebProfiler] Detect empty file paths in file viewer
This was referenced Nov 26, 2018
Merged
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually link directories sometimes :) now looks like: