[PropertyAccessor] fix encoding of cache keys #29313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 25, 2018
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #29293 |
| License | MIT |
| Doc PR | - |
nicolas-grekas
force-pushed
the
pa-fix
branch
2 times, most recently
from
e3174fc to
a22ae3c
Compare
Member
|
Can we add a test? |
nicolas-grekas
force-pushed
the
pa-fix
branch
from
a22ae3c to
9e454c4
Compare
Member
Author
|
Now with a basic test case. |
nicolas-grekas
force-pushed
the
pa-fix
branch
from
9e454c4 to
4568a0c
Compare
fabpot
approved these changes
Nov 26, 2018
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Nov 26, 2018
…kas) This PR was merged into the 3.4 branch. Discussion ---------- [PropertyAccessor] fix encoding of cache keys | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29293 | License | MIT | Doc PR | - Commits ------- 4568a0c [PropertyAccessor] fix encoding of cache keys
This was referenced Nov 26, 2018
Merged
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.