LoggingTranslator should implement Symfony\Contracts\Translation\TranslatorInterface #29090
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desmax
force-pushed
the
logging-translator-fix
branch
from
b75b3a8 to
65f321f
Compare
xabbuh
approved these changes
Nov 5, 2018
derrabus
approved these changes
Nov 5, 2018
nicolas-grekas
approved these changes
Nov 5, 2018
stof
approved these changes
Nov 5, 2018
ogizanagi
approved these changes
Nov 5, 2018
Member
|
Thank you @desmax. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 6, 2018
…lation\TranslatorInterface (desmax) This PR was merged into the 4.2-dev branch. Discussion ---------- LoggingTranslator should implement Symfony\Contracts\Translation\TranslatorInterface | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29089 | License | MIT While autowiring Translator using `Symfony\Contracts\Translation\TranslatorInterface` symfony complains that wrong service was injected, because LoggingTranslator does not implement new interface. Commits ------- 65f321f LoggingTranslator should implement Symfony\Contracts\Translation\TranslatorInterface
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While autowiring Translator using
Symfony\Contracts\Translation\TranslatorInterfacesymfony complains that wrong service was injected, because LoggingTranslator does not implement new interface.