[Serializer] Allow null values when denormalizing with constructor missing data #29076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
reviewed
Nov 5, 2018
src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Nov 6, 2018
nicolas-grekas
changed the title
ogizanagi
approved these changes
Nov 6, 2018
fbourigault
approved these changes
Nov 7, 2018
dunglas
approved these changes
Nov 8, 2018
dunglas
force-pushed
the
denormalizer_null
branch
from
d63d8e3 to
5fd0f3f
Compare
Member
|
Thanks @danut007ro. |
dunglas
added a commit
that referenced
this pull request
Nov 8, 2018
…structor missing data (danut007ro) This PR was squashed before being merged into the 4.1 branch (closes #29076). Discussion ---------- [Serializer] Allow null values when denormalizing with constructor missing data | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT When using `default_constructor_arguments` to denormalize objects, `null` values for a parameter weren't processed, so instantiating was failing. Commits ------- 5fd0f3f [Serializer] Allow null values when denormalizing with constructor missing data
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
default_constructor_argumentsto denormalize objects,nullvalues for a parameter weren't processed, so instantiating was failing.