[FrameworkBundle] Display a proper warning for deprecated --env and --no-debug options #29002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
Status: Reviewed
and removed
Status: Needs Review
labels
ogizanagi
approved these changes
Oct 28, 2018
| if ($input->hasParameterOption('--no-debug', true)) { | ||
| @trigger_error('The "--no-debug" option is deprecated since Symfony 4.2. Set the "APP_DEBUG" environment variable to "0" instead.', E_USER_DEPRECATED); | ||
| $notice = 'The "--no-debug" option is deprecated since Symfony 4.2. Set the "APP_DEBUG" environment variable to "0" instead.'; | ||
| ($io ?: new SymfonyStyle($input, $output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output))->warning($notice); |
Contributor
There was a problem hiding this comment.
Not much relevant, but:
- $io ?: new SymfonyStyle
+ $io ?? new SymfonyStyle| if ($input->hasParameterOption(array('-e', '--env'), true)) { | ||
| @trigger_error('The "--env" option and its "-e" shortcut are deprecated since Symfony 4.2. Set the "APP_ENV" environment variable instead.', E_USER_DEPRECATED); | ||
| $notice = 'The "--env" option and its "-e" shortcut are deprecated since Symfony 4.2. Set the "APP_ENV" environment variable instead.'; | ||
| $io = new SymfonyStyle($input, $output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output); |
Contributor
There was a problem hiding this comment.
What about using ->getErrorStyle() instead?
chalasr
force-pushed
the
visible-deprecated-opts
branch
2 times, most recently
from
a195b0c to
e3aadcb
Compare
Tobion
approved these changes
Oct 28, 2018
fabpot
reviewed
Oct 28, 2018
| { | ||
| if ($input->hasParameterOption(array('-e', '--env'), true)) { | ||
| @trigger_error('The "--env" option and its "-e" shortcut are deprecated since Symfony 4.2. Set the "APP_ENV" environment variable instead.', E_USER_DEPRECATED); | ||
| $notice = 'The "--env" option and its "-e" shortcut are deprecated since Symfony 4.2. Set the "APP_ENV" environment variable instead.'; |
Member
There was a problem hiding this comment.
... since Symfony 4.2, set the ...
…-no-debug options
chalasr
force-pushed
the
visible-deprecated-opts
branch
from
e3aadcb to
a40048e
Compare
fabpot
approved these changes
Oct 28, 2018
Member
|
Thank you @chalasr. |
fabpot
added a commit
that referenced
this pull request
Oct 28, 2018
…d --env and --no-debug options (chalasr) This PR was merged into the 4.2-dev branch. Discussion ---------- [FrameworkBundle] Display a proper warning for deprecated --env and --no-debug options | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Currently hidden (remember #23328) Commits ------- a40048e [FrameworkBundle] Display a proper warning for deprecated --env and --no-debug options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently hidden (remember #23328)