Skip to content

[WIP] Remove check for hardcoded message_bus service name #28959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ajgarlag wants to merge 2 commits into from
Closed

[WIP] Remove check for hardcoded message_bus service name #28959

ajgarlag wants to merge 2 commits into from

Conversation

@ajgarlag
Copy link
Contributor

@ajgarlag ajgarlag commented Oct 23, 2018 •
edited
Loading

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

There is no need to have a bus named message_bus for the MessengerPass to work.

@ajgarlag ajgarlag changed the title [WIP] Remove unneeded check. Remove check for hardcoded message_bus service name Oct 23, 2018
@ajgarlag ajgarlag changed the title Remove check for hardcoded message_bus service name [WIP] Remove check for hardcoded message_bus service name Oct 23, 2018
@ajgarlag
Copy link
Contributor Author

ajgarlag commented Oct 23, 2018

Closed, because I need to work more with this component to understand it properly.

@ajgarlag ajgarlag closed this Oct 23, 2018
@ro0NL ro0NL mentioned this pull request Oct 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ajgarlag