[Messenger] rename "envelope items" and move them in the "Stamp" namespace #28911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
messenger-stamps
branch
from
722354c to
74284f6
Compare
ogizanagi
suggested changes
Oct 18, 2018
src/Symfony/Component/Messenger/DataCollector/MessengerDataCollector.php
Show resolved
Hide resolved
nicolas-grekas
force-pushed
the
messenger-stamps
branch
from
74284f6 to
0ad2cb9
Compare
chalasr
approved these changes
Oct 19, 2018
weaverryan
approved these changes
Oct 19, 2018
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
I <3 all of this! The Stamp is much more understandable to me than the EnvelopeItems. We are now, for example, "stamping the message validation configuration".
nicolas-grekas
added a commit
that referenced
this pull request
Oct 20, 2018
…he "Stamp" namespace (nicolas-grekas) This PR was merged into the 4.2-dev branch. Discussion ---------- [Messenger] rename "envelope items" and move them in the "Stamp" namespace | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Right now, envelope items are scattered in different sub namespaces and use the "Configuration" suffix. This makes them hard to discover. This PR creates a new `Stamp` namespace and moves all "envelope items" there, renaming them to use the "stamp" terminology. From the changelog: * `Envelope`'s constructor and `with` method now accept `StampInterface` objects as variadic parameters * Renamed `EnvelopeItemInterface` to `StampInterface` * Renamed and moved `ReceivedMessage`, `ValidationConfiguration` and `SerializerConfiguration` in the `Stamp` namespace * Removed the `WrapIntoReceivedMessage` (it's untested and unused) Commits ------- 0ad2cb9 [Messenger] rename "envelope items" and move them in the "Stamp" namespace
Contributor
|
Oh my god. You hipsters! |
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, envelope items are scattered in different sub namespaces and use the "Configuration" suffix.
This makes them hard to discover.
This PR creates a new
Stampnamespace and moves all "envelope items" there, renaming them to use the "stamp" terminology.From the changelog:
Envelope's constructor andwithmethod now acceptStampInterfaceobjects as variadic parametersEnvelopeItemInterfacetoStampInterfaceReceivedMessage,ValidationConfigurationandSerializerConfigurationin theStampnamespaceWrapIntoReceivedMessage(it's untested and unused)