'yml' is not a format and shouldn't be visible as constant from 'YamlEncoder' #28830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
approved these changes
Oct 12, 2018
fabpot
approved these changes
Oct 12, 2018
Member
|
Thank you @mcsky. |
fabpot
added a commit
that referenced
this pull request
Oct 12, 2018
…nt from 'YamlEncoder' (kevin-biig) This PR was merged into the 4.2-dev branch. Discussion ---------- 'yml' is not a format and shouldn't be visible as constant from 'YamlEncoder' A little fix of my [previous PR](#28815) This PR changes the constant visibility of the `yml` format as private. Because as @stof [mentionned](#28815 (comment)) `yml` isn't a format, so the constant shoudn't be public. Otherwise, this will be confusing while using autocomplete, you see two formats. The user can ask himself if there is a difference between `yaml` / `yml`. No need of that :) | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Fixed tickets | - | License | MIT | Doc PR | Commits ------- 674b359 'yml' is not a format and shouldn't be visible as constant from 'YamlEncoder' class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little fix of my previous PR
This PR changes the constant visibility of the
ymlformat as private.Because as @stof mentionned
ymlisn't a format, so the constant shoudn't be public.Otherwise, this will be confusing while using autocomplete, you see two formats. The user can ask himself if there is a difference between
yaml/yml.No need of that :)