[Routing] allow using the compiled URL generator without dumping PHP code #28774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
route-static-generator
branch
from
d0de579 to
b6d9263
Compare
nicolas-grekas
force-pushed
the
route-static-generator
branch
from
b6d9263 to
15f1ac3
Compare
Member
Author
|
Now part of #28865 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial resurrection of #25909 about the URL generator only.
This PR makes the Routing component easier by allowing to use a compiled generator without dumping it as PHP code. A simple PHP array + a generic class does it.
Another PR is on its way to do the same for the matcher.
On the plane to SF :)