Skip to content

[BrowserKit] throw exception when request() wasn't called #28592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Sep 29, 2018
Merged

[BrowserKit] throw exception when request() wasn't called #28592

nicolas-grekas merged 1 commit into from
Sep 29, 2018

Conversation

@xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 25, 2018

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR #27807 (comment)

@nicolas-grekas nicolas-grekas added this to the next milestone Sep 25, 2018
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Sep 29, 2018

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 41cfde1 into symfony:master Sep 29, 2018
nicolas-grekas added a commit that referenced this pull request Sep 29, 2018
@nicolas-grekas
bug #28592 [BrowserKit] throw exception when request() wasn't called …
3afe4e7 
…(xabbuh)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[BrowserKit] throw exception when request() wasn't called

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | #27807 (comment)

Commits
-------

41cfde1 throw exception when request() wasn't called
@xabbuh xabbuh deleted the pr-27807 branch September 30, 2018 07:38
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.2 Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@javiereguiluz javiereguiluz javiereguiluz approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof approved these changes

Assignees

No one assigned

Labels

BrowserKit Bug Status: Reviewed

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@xabbuh @nicolas-grekas @javiereguiluz @stof @carsonbot