[FrameworkBundle] Register the messenger data collector only when the profiler is enabled #28418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
approved these changes
Sep 10, 2018
nicolas-grekas
approved these changes
Sep 10, 2018
sroze
approved these changes
Sep 10, 2018
Contributor
|
Thank you @pierredup. |
sroze
added a commit
that referenced
this pull request
Sep 10, 2018
…ly when the profiler is enabled (pierredup) This PR was merged into the 4.1 branch. Discussion ---------- [FrameworkBundle] Register the messenger data collector only when the profiler is enabled | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28350 | License | MIT | Doc PR | N/A The data collector for the messenger is currently unconditionally registered, which causes increased memory usage even in production. Instead, it should only be registered along with the rest of the data collectors only when the profiler is enabled Commits ------- bd3a66b Register the messenger data collector only when the profiler is enabled
chalasr
pushed a commit
that referenced
this pull request
Sep 16, 2018
…if messenger is not enabled (chalasr) This PR was merged into the 4.1 branch. Discussion ---------- [FrameworkBundle] Don't register MessengerDataCollector if messenger is not enabled | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | no (not yet released) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Will fix `deps=high` SecurityBundle's build once merged up to master which is broken since #28418 Commits ------- e64ceb5 [FrameworkBundle] Don't register MessengerDataCollector if messenger is not enabled
|
Hi guys, how to test this patch in existing project? as i asume this bugfix will be released in 4.1.5 right? |
Contributor
|
Yes, it will. In the meantime, you could use the version |
Merged
|
v4.1.6 ) do'nt release memory in prod: http://prntscr.com/ld5yu3 |
Member
|
@zeves095 Can you open a new issue with enough details to reproduce? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The data collector for the messenger is currently unconditionally registered, which causes increased memory usage even in production. Instead, it should only be registered along with the rest of the data collectors only when the profiler is enabled