[HttpKernel][FrameworkBundle] Fix escaping of serialized payloads passed to test clients #28344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Sep 3, 2018
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #28125 |
| License | MIT |
| Doc PR | - |
fabpot
approved these changes
Sep 3, 2018
fabpot
requested changes
Sep 3, 2018
nicolas-grekas
force-pushed
the
fix-export-client
branch
from
432bf05 to
a468188
Compare
Member
|
Looks like tests are broken with this change. |
…sed to test clients
nicolas-grekas
force-pushed
the
fix-export-client
branch
from
a468188 to
2554554
Compare
Member
Author
|
Fixed, should be green soon. |
fabpot
approved these changes
Sep 4, 2018
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 4, 2018
…ayloads passed to test clients (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [HttpKernel][FrameworkBundle] Fix escaping of serialized payloads passed to test clients | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #28125 | License | MIT | Doc PR | - Commits ------- 2554554 [HttpKernel][FrameworkBundle] Fix escaping of serialized payloads passed to test clients
This was referenced Sep 30, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.