[Translation] fix perf of lint:xliff command #28152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
Translation
Bug
Status: Reviewed
and removed
Status: Needs Review
labels
javiereguiluz
approved these changes
Aug 7, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Aug 8, 2018
This PR was merged into the 4.1 branch. Discussion ---------- [Translation] fix perf of lint:xliff command | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27564 | License | MIT | Doc PR | - #27653 has been merged on master as an improvement, but the perf issue is a killer. Our CI spends 1 minutes on just a few translation test cases. Only 4.1 has this behavior. That's a bug. Commits ------- 02c69b1 [Translation] fix perf of lint:xliff command
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#27653 has been merged on master as an improvement, but the perf issue is a killer.
Our CI spends 1 minutes on just a few translation test cases.
Only 4.1 has this behavior. That's a bug.