[Travis] make CI faster by always using PHP 7.1 for composer update #28111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Aug 2, 2018
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
nicolas-grekas
force-pushed
the
travis-composer-php71
branch
23 times, most recently
from
69144ec to
7081c16
Compare
nicolas-grekas
force-pushed
the
travis-composer-php71
branch
from
7081c16 to
010cd75
Compare
stof
reviewed
Aug 2, 2018
| nanoseconds() { | ||
| if [[ $PHP = 5.* ]]; then | ||
| composer () { | ||
| $HOME/.phpenv/versions/$TRAVIS_PHP_VERSION/bin/composer config platform.php $TRAVIS_PHP_VERSION |
Member
There was a problem hiding this comment.
this should be the exact PHP version. $TRAVIS_PHP_VERSION will make it use 5.5 AFAICT, which means 5.5.0. this might cause issues with packages having 5.5.9 as min version.
Member
Author
|
Closing in favor of #28114 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.