[FrameworkBundle] Fixed phpdoc in MicroKernelTrait::configureRoutes() #27870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vudaltsov
commented
Jul 6, 2018
vudaltsov
commented
| Q | A |
|---|---|
| Branch? | 4.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
nicolas-grekas
approved these changes
Jul 6, 2018
chalasr
reviewed
Jul 6, 2018
| * | ||
| * $routes->import('config/routing.yml'); | ||
| * $routes->add('/admin', 'AppBundle:Admin:dashboard', 'admin_dashboard'); | ||
| * $routes->add('/admin', 'App\Controller\AdminController::dashboardAction', 'admin_dashboard'); |
Member
There was a problem hiding this comment.
I suggest to drop the Action suffix (as recommended by https://symfony.com/doc/current/best_practices/controllers.html#controller-action-naming)
Contributor
Author
|
@chalasr , done! |
chalasr
approved these changes
Jul 6, 2018
xabbuh
reviewed
Jul 6, 2018
| * | ||
| * $routes->import('config/routing.yml'); | ||
| * $routes->add('/admin', 'AppBundle:Admin:dashboard', 'admin_dashboard'); | ||
| * $routes->add('/admin', 'App\Controller\AdminController::dashboard', 'admin_dashboard'); |
Member
There was a problem hiding this comment.
Shouldn't this be a single colon now?
Member
There was a problem hiding this comment.
didn't we deprecate single colon syntax?
Contributor
Author
There was a problem hiding this comment.
Here's were it happened #26085
So if I got it right, we now have Class::method instead of a:b:c and a:b
Contributor
Author
There was a problem hiding this comment.
deprecation for OAuth bundle says the same
xabbuh
approved these changes
Jul 6, 2018
nicolas-grekas
force-pushed
the
routing-phpdoc-fix
branch
from
d9f62dd to
948c841
Compare
Member
|
Thank you @vudaltsov. |
nicolas-grekas
added a commit
that referenced
this pull request
Jul 7, 2018
…igureRoutes() (vudaltsov) This PR was merged into the 4.1 branch. Discussion ---------- [FrameworkBundle] Fixed phpdoc in MicroKernelTrait::configureRoutes() | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 948c841 [FrameworkBundle] Fixed phpdoc in MicroKernelTrait::configureRoutes()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.