4.1 #27816
Closed
4.1 #27816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This was referenced Jul 3, 2018
Merged
Author
nicolas-grekas
added a commit
that referenced
this pull request
Jul 9, 2018
… entities and discrimination map (sroze) This PR was merged into the 4.1 branch. Discussion ---------- [Serializer] Fix serialization of items with groups across entities and discrimination map | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27816, #27641 | License | MIT | Doc PR | ø I believe this approach is better than the one taken in #27816. At least, it's an alternative :) Commits ------- c648b93 Fix serialization of abstract items with groups across multiple entities
fabpot
added a commit
that referenced
this pull request
Jul 19, 2018
This PR was merged into the 4.1 branch. Discussion ---------- [Serializer] Supports nested abstract items | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27816, #27641 | License | MIT | Doc PR | ø This adds support for nested "abstract" objects. Commits ------- ec4b04b Supports nested "abstract" object while serializing and de-serializing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing this bugs:
voodoo-dn/serializer-bug@0aa4a57
On normalization trying get property from class which not exists(because merged whole attribute list from class discriminator map)
voodoo-dn/serializer-bug@41ae6e8
Associated objects are not deserialized
For example: DummyA has association with DummyB, but on deserialization(json string for example) instead of passing DummyB object via DummyA::setDummyB(), array passed to this method.