Skip to content

[VarDumper] show proxified class on hover #27766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fabpot merged 1 commit into from
Jun 30, 2018
Merged

[VarDumper] show proxified class on hover #27766

fabpot merged 1 commit into from
Jun 30, 2018

Conversation

@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jun 29, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

capture d ecran de 2018-06-29 08-18-59

@nicolas-grekas nicolas-grekas added this to the next milestone Jun 29, 2018
@javiereguiluz
Copy link
Member

javiereguiluz commented Jun 29, 2018

I like this a lot! Just a minor comment: I wonder if instead of App\Foo@proxy we should display it as App\Foo proxy or Proxy of App\Foo class ?

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Jun 29, 2018

There is one technical constraint: the last \ controls what's dumped (everything after it - Foo@proxy in the example) vs what's displayed on hover (the full string - Foo_9991422 - App\Foo@proxy). I'm not sure this proposal would fit.

@fabpot
Copy link
Member

fabpot commented Jun 30, 2018

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 955494c into symfony:master Jun 30, 2018
fabpot added a commit that referenced this pull request Jun 30, 2018
@fabpot
feature #27766 [VarDumper] show proxified class on hover (nicolas-gre…
9bb990f 
…kas)

This PR was merged into the 4.2-dev branch.

Discussion
----------

[VarDumper] show proxified class on hover

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

![capture d ecran de 2018-06-29 08-18-59](https://user-images.githubusercontent.com/243674/42076362-2ab0dd1c-7b75-11e8-9243-5e2f78afe870.png)

Commits
-------

955494c [VarDumper] show proxified class on hover
@nicolas-grekas nicolas-grekas deleted the dump-proxy branch July 1, 2018 07:50
@nicolas-grekas nicolas-grekas modified the milestones: next, 4.2 Nov 1, 2018
This was referenced Nov 3, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

+1 more reviewer

@ogizanagi ogizanagi ogizanagi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature Status: Reviewed VarDumper

Projects

None yet

Milestone

4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@nicolas-grekas @javiereguiluz @fabpot @ogizanagi @carsonbot