[Routing] fix too much greediness in host-matching regex #27736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jun 27, 2018
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 4.1 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #27721 |
| License | MIT |
| Doc PR | - |
carsonbot
added
Status: Needs Review
Routing
Bug
and removed
Status: Needs Review
labels
stof
approved these changes
Jun 27, 2018
nicolas-grekas
force-pushed
the
route-fix
branch
3 times, most recently
from
471eb29 to
5a37f90
Compare
Member
Author
|
(failure unrelated) |
nicolas-grekas
force-pushed
the
route-fix
branch
from
5a37f90 to
e16b302
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jun 28, 2018
…nicolas-grekas) This PR was merged into the 4.1 branch. Discussion ---------- [Routing] fix too much greediness in host-matching regex | Q | A | ------------- | --- | Branch? | 4.1 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27721 | License | MIT | Doc PR | - Commits ------- e16b302 [Routing] fix too much greediness in host-matching regex
This was referenced Jun 29, 2018
|
Hi, |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.