[SecurityBundle] Add json login ldap #27650
Conversation
|
This needs some tests, at least a unit one for the factory, at best a functional one. |
|
@chalasr others LDAP SecurityListenerFactory are not tested, it's a bit difficult and it's just an improvement of existing behavior. (json + ldap) |
@ronfroy that's too bad but still, new code should be tested, at least ensuring that the container can compile with your addition in order to prevent regressions. That should not be hard, adding a |
|
@chalasr done |
nicolas-grekas
changed the title
nicolas-grekas
left a comment
nicolas-grekas
left a comment
There was a problem hiding this comment.
worth a line in the CHANGELOG file of the bundle - an also a doc PR? LGTM otherwise, thanks.
| stateless: true | ||
| anonymous: true | ||
| json_login_ldap: | ||
| check_path: /login |
There was a problem hiding this comment.
I don't think we align values usually.
| anonymous: true | ||
| json_login: | ||
| check_path: /chk | ||
| check_path: /chk |
There was a problem hiding this comment.
@ronfroy If this has to be changed, it must be done on the lowest branch where it exists to prevent merge conflicts (but I don't think it's worth it, we should just keep it in mind for new code). Can you please revert this change? Same for the custom_handlers.yml file below
|
@chalasr done |
|
Thank you @ronfroy. |
This PR was squashed before being merged into the 4.2-dev branch (closes #27650). Discussion ---------- [SecurityBundle] Add json login ldap | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Add a simple from_login_ldap on firewall types to let authenticate with ldap with json API Commits ------- 2b2dfd2 [SecurityBundle] Add json login ldap
|
@ronfroy Note that github does not recognize your local git user so your contribs aren't linked to your github profile. See https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/ for fixing it |
This PR was merged into the master branch. Discussion ---------- json-login-ldap symfony/symfony#27650 Commits ------- de28118 json-login-ldap
5 participants
Add a simple from_login_ldap on firewall types to let authenticate with ldap with json API