[VarDumper] Fix dumping ArrayObject and ArrayIterator instances #27591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
VarDumper
Bug
Status: Needs Work
and removed
Status: Needs Review
labels
fabpot
requested changes
Jun 14, 2018
| ); | ||
|
|
||
| public static function castArrayObject(\ArrayObject $c, array $a, Stub $stub, $isNested) | ||
| public static function castArrayObject($c, array $a, Stub $stub, $isNested) |
Member
There was a problem hiding this comment.
Now that this method supports more than just ArrayObject, it should be renamed, right?
Member
There was a problem hiding this comment.
Or for BC, we can probably keep this method signature as is and create a castArrayIterator one and both calling a private one?
Member
Author
|
updated Status: needs review |
nicolas-grekas
force-pushed
the
dump-arrayiterator
branch
from
70dc6e4 to
1ad0d6d
Compare
stof
requested changes
Jun 14, 2018
Member
stof
left a comment
stof
left a comment
There was a problem hiding this comment.
Please add tests covering these cases
nicolas-grekas
force-pushed
the
dump-arrayiterator
branch
from
1ad0d6d to
89aaae9
Compare
Member
Author
|
@stof tests added |
stof
approved these changes
Jun 14, 2018
nicolas-grekas
force-pushed
the
dump-arrayiterator
branch
from
89aaae9 to
3ecabfc
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jun 15, 2018
…ances (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [VarDumper] Fix dumping ArrayObject and ArrayIterator instances | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Properties added on child classes of `ArrayObject` and `ArrayIterator`, or dynamic properties added on instances of them were now properly dumped. This fixes it.  Commits ------- 3ecabfc [VarDumper] Fix dumping ArrayObject and ArrayIterator instances
This was referenced Jun 25, 2018
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properties added on child classes of
ArrayObjectandArrayIterator, or dynamic properties added on instances of them were now properly dumped. This fixes it.