Skip to content

[DebugBundle] DebugBundle::registerCommands should be noop #27496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Jun 4, 2018
Merged

[DebugBundle] DebugBundle::registerCommands should be noop #27496

nicolas-grekas merged 1 commit into from
Jun 4, 2018
+6 −0

Conversation

@ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Jun 4, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27493
License MIT
Doc PR N/A

@ogizanagi ogizanagi added this to the 4.1 milestone Jun 4, 2018
@ogizanagi ogizanagi mentioned this pull request Jun 4, 2018
Closed
@alcohol
Copy link
Contributor

alcohol commented Jun 4, 2018

Can confirm this fixes #27493

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jun 4, 2018

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit dd4b0ed into symfony:4.1 Jun 4, 2018
nicolas-grekas added a commit that referenced this pull request Jun 4, 2018
@nicolas-grekas
bug #27496 [DebugBundle] DebugBundle::registerCommands should be noop…
7605706 
… (ogizanagi)

This PR was merged into the 4.1 branch.

Discussion
----------

[DebugBundle] DebugBundle::registerCommands should be noop

| Q             | A
| ------------- | ---
| Branch?       | 4.1 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #27493   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

dd4b0ed [DebugBundle] DebugBundle::registerCommands should be noop
@ogizanagi ogizanagi deleted the fix/debug_bundle/noop_register_commands branch June 4, 2018 19:28
@fabpot fabpot mentioned this pull request Jun 25, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees

No one assigned

Labels

Bug DebugBundle Status: Reviewed

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

5 participants

@ogizanagi @alcohol @nicolas-grekas @fabpot @carsonbot