[DI] never inline lazy services #27366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
di-lazy-proto
branch
from
bfa3c85 to
5d73382
Compare
Member
|
this is to ensure that the special logic running in the factory method can always be called, right ? |
stof
approved these changes
May 24, 2018
Member
Author
exactly yes |
nicolas-grekas
force-pushed
the
di-lazy-proto
branch
from
5d73382 to
ab45448
Compare
nicolas-grekas
force-pushed
the
di-lazy-proto
branch
from
ab45448 to
a147eb7
Compare
nicolas-grekas
force-pushed
the
di-lazy-proto
branch
from
a147eb7 to
3b4d7ab
Compare
nicolas-grekas
added a commit
that referenced
this pull request
May 25, 2018
This PR was merged into the 2.8 branch. Discussion ---------- [DI] never inline lazy services | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | - | License | MIT | Doc PR | - Should apply also: - to deprecated services since 2.8 - to errored services since 3.4 Commits ------- 3b4d7ab [DI] never inline lazy services
Merged
This was referenced Jun 25, 2018
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should apply also: