Skip to content

[SecurityBundle] Fix FirewallContext constructor 3.4 compatibility #27280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chalasr wants to merge 1 commit into from
Closed

[SecurityBundle] Fix FirewallContext constructor 3.4 compatibility #27280

chalasr wants to merge 1 commit into from

Conversation

@chalasr
Copy link
Member

@chalasr chalasr commented May 16, 2018

Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #24805 (comment)
License MIT
Doc PR n/a

@chalasr chalasr mentioned this pull request May 16, 2018
Merged
@nicolas-grekas nicolas-grekas added this to the 2.7 milestone May 16, 2018
@nicolas-grekas
Copy link
Member

nicolas-grekas commented May 16, 2018 •
edited
Loading

Thanks for the PR. I'm going to do it differently (2.8 to 3.4 merge in progress).

@chalasr chalasr deleted the firewallctx-config-arg branch May 16, 2018 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

SecurityBundle Status: Needs Review

Projects

None yet

Milestone

2.7

Development

Successfully merging this pull request may close these issues.

3 participants

@chalasr @nicolas-grekas @carsonbot