[Debug][WebProfilerBundle] Fix setting file link format #27074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Apr 27, 2018
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | ,p |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #26917 |
| License | MIT |
| Doc PR | - |
This was referenced Apr 27, 2018
nicolas-grekas
force-pushed
the
file-link-format
branch
2 times, most recently
from
9d958d6 to
eba643e
Compare
nicolas-grekas
force-pushed
the
file-link-format
branch
from
eba643e to
a4a1645
Compare
lyrixx
approved these changes
Apr 30, 2018
Member
Author
|
Thank you @lyrixx. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 30, 2018
…yrixx, nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [Debug][WebProfilerBundle] Fix setting file link format | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | ,p | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #26917 | License | MIT | Doc PR | - Commits ------- a4a1645 [Debug][WebProfilerBundle] Fix setting file link format 620f90d [Debug] Fixed the formatPath when a custom fileLinkFormat is defined
nicolas-grekas
added a commit
that referenced
this pull request
May 29, 2018
This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] fix registering IDE links | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27194 | License | MIT | Doc PR | - Reverts some changes made in #27074 in `FrameworkBundle::boot()` that create the linked issue. Leverages changes done in #26138 instead. Commits ------- 92e3023 [HttpKernel] fix registering IDE links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.