Skip to content

[VarDumper] Fix HtmlDumper classes match #27064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolas-grekas merged 1 commit into from
Apr 26, 2018
Merged

[VarDumper] Fix HtmlDumper classes match #27064

nicolas-grekas merged 1 commit into from
Apr 26, 2018

Conversation

@ogizanagi
Copy link
Contributor

@ogizanagi ogizanagi commented Apr 26, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27045
License MIT
Doc PR N/A

@ogizanagi ogizanagi added this to the 3.4 milestone Apr 26, 2018
@ogizanagi ogizanagi mentioned this pull request Apr 26, 2018
Closed
@lyrixx
Copy link
Member

lyrixx commented Apr 26, 2018

I don't understand the code, but now it works as expected ;)

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Apr 26, 2018

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit 229430f into symfony:3.4 Apr 26, 2018
nicolas-grekas added a commit that referenced this pull request Apr 26, 2018
@nicolas-grekas
bug #27064 [VarDumper] Fix HtmlDumper classes match (ogizanagi)
df20e80 
This PR was merged into the 3.4 branch.

Discussion
----------

[VarDumper] Fix HtmlDumper classes match

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #27045   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

229430f [VarDumper] Fix HtmlDumper classes match
@ogizanagi ogizanagi deleted the fix/html_dumper_class_matches branch April 26, 2018 14:40
This was referenced Apr 30, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lyrixx lyrixx lyrixx approved these changes

@chalasr chalasr chalasr approved these changes

Assignees

No one assigned

Labels

Bug Status: Reviewed VarDumper

Projects

None yet

Milestone

3.4

Development

Successfully merging this pull request may close these issues.

5 participants

@ogizanagi @lyrixx @nicolas-grekas @chalasr @carsonbot