Skip to content

Conversation

@c960657
Copy link
Contributor

@c960657 c960657 commented Apr 23, 2018

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

A follow-up to #24699 with a few code and documentation fixes for post-merge review comments by @stof.

@javiereguiluz
Copy link
Member

In the PHPdoc of joinAssoc() there are some minor issue that should be fixed too:

  • ... is joined ... -> ... are joined ...
  • The result of the example ('foo=bar, baz, baz="a b c"') should be 'foo=abc, bar, baz="a b c"'

Thanks!

@fabpot fabpot force-pushed the header-utils-fixes branch from a05455f to d7c3c79 Compare April 27, 2018 09:35
@fabpot
Copy link
Member

fabpot commented Apr 27, 2018

Thank you @c960657.

@fabpot fabpot merged commit d7c3c79 into symfony:master Apr 27, 2018
fabpot added a commit that referenced this pull request Apr 27, 2018
This PR was squashed before being merged into the 4.1-dev branch (closes #27019).

Discussion
----------

[HttpFoundation] Fixes to new HeaderUtils class

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

A follow-up to #24699 with a few code and documentation fixes for post-merge review comments by @stof.

Commits
-------

d7c3c79 [HttpFoundation] Fixes to new HeaderUtils class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants