[DI][FrameworkBundle] Use container.hidden tag to hide services from debug:container #26891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Apr 11, 2018
Member
weaverryan
left a comment
weaverryan
left a comment
There was a problem hiding this comment.
Obviously, you know I like this idea. Particularly, it's important to now show ALL services in debug:container. The ability to then hide a few of the most internal, is great.
| protected function execute(InputInterface $input, OutputInterface $output) | ||
| { | ||
| if ($input->getOption('show-private')) { | ||
| @trigger_error('The "--show-private" option is a no-op and is deprecated since Symfony 4.1.', E_USER_DEPRECATED); |
Member
There was a problem hiding this comment.
option no longer has any effect and is deprecated ...
stof
reviewed
Apr 12, 2018
Member
stof
left a comment
stof
left a comment
There was a problem hiding this comment.
The new tag must be added in the whitelist of the UnusedTags pass, to avoid complaining about this tag not being during the container building.
| return $builder->getAlias($serviceId); | ||
| } | ||
|
|
||
| if ('service_container' == $serviceId) { |
nicolas-grekas
force-pushed
the
container.hidden
branch
from
c1d7918 to
37054b8
Compare
Member
Author
|
Replaced by #26921 |
fabpot
added a commit
that referenced
this pull request
Apr 20, 2018
… a dot (nicolas-grekas) This PR was merged into the 4.1-dev branch. Discussion ---------- [DI][FrameworkBundle] Hide service ids that start with a dot | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #26630 | License | MIT | Doc PR | - Now that services are private by default, `debug:container` should display them by default. In fact, the public/private concept should not trigger a difference in visibility for this command. Instead, I propose to handle service ids that start with a dot as hidden services. PR should be ready. (For reference, I tried using a tag instead in #26891, but that doesn't work in practice when working on the implementation.) Commits ------- cea051e [DI][FrameworkBundle] Hide service ids that start with a dot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that services are private by default, the
debug:containershould display them by default.In fact, the public/private concept should not trigger a difference in visibility for this command.
Instead, I propose to handle a new
container.hiddentag, for the purpose of tagging services as hidden (~internal).I now need to apply the tag to more services created internally.
Any comments at this stage?