[Messenger] Rename the middleware tag #26862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….bus_middleware`
ro0NL
approved these changes
Apr 8, 2018
ogizanagi
approved these changes
Apr 8, 2018
chalasr
approved these changes
Apr 9, 2018
sroze
added a commit
that referenced
this pull request
Apr 9, 2018
This PR was merged into the 4.1-dev branch. Discussion ---------- [Messenger] Rename the middleware tag | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT | Doc PR | symfony/symfony-docs#9437 After a using it for a bit of time, it's weird to have the `messenger.message_handler` tag while using the `message_bus_middleware` tag for the middlewares. I propose to rename the tag from `message_bus_middleware` to `messenger.bus_middleware` to keep some consistency. Commits ------- dd18445 Rename the middleware tag from `message_bus_middleware` to `messenger.bus_middleware`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a using it for a bit of time, it's weird to have the
messenger.message_handlertag while using themessage_bus_middlewaretag for the middlewares.I propose to rename the tag from
message_bus_middlewaretomessenger.bus_middlewareto keep some consistency.