[HttpFoundation] Have MigratingSessionHandler implement SessionUpdateTimestampHandlerInterface #26828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
fabpot
approved these changes
Apr 6, 2018
Tobion
approved these changes
Apr 6, 2018
Contributor
Tobion
left a comment
Tobion
left a comment
There was a problem hiding this comment.
A test for this would be nice
…TimestampHandlerInterface
nicolas-grekas
force-pushed
the
mig-strict
branch
from
8e0c20f to
5d7117b
Compare
Member
Author
|
test added |
Contributor
|
Good catch, thanks Nicolas. |
Tobion
added a commit
that referenced
this pull request
Apr 7, 2018
…SessionUpdateTimestampHandlerInterface (nicolas-grekas) This PR was merged into the 4.1-dev branch. Discussion ---------- [HttpFoundation] Have MigratingSessionHandler implement SessionUpdateTimestampHandlerInterface | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Forgotten in #26096 Commits ------- 5d7117b [HttpFoundation] Have MigratingSessionHandler implement SessionUpdateTimestampHandlerInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgotten in #26096