[PropertyInfo] Types should not be extracted from private constructor #26777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyerbaptiste
force-pushed
the
fix_extract_from_private_constructor
branch
from
5cc429d to
ef0b562
Compare
Member
|
I'm not against this change, but to me it's not an error. As we can see in you test, the |
Contributor
Author
|
Right, after reflection with @dunglas, we are not so sure anymore! I prefer to close for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #25605, types are now extracted from constructors. But, IMO, types should not be extracted when constructor is private.
cc @lyrixx