[Messenger] Make NoHandlerForMessageException a logic exception #26706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Mar 29, 2018
fabpot
approved these changes
Mar 30, 2018
Member
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Mar 30, 2018
…ception (ogizanagi) This PR was merged into the 4.1-dev branch. Discussion ---------- [Messenger] Make NoHandlerForMessageException a logic exception | Q | A | ------------- | --- | Branch? | master <!-- see below --> | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #26648 (comment) <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A <!-- required for new features --> To me, a missing handler for a message is a program logic exception (or misconfiguration). Even if it's only detected at runtime here. It's the same as `ServiceNotFoundException` which even is an `\InvalidArgumentException`. Could eventually also be the case here. Commits ------- 0489bbd [Messenger] Make NoHandlerForMessageException a logic exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To me, a missing handler for a message is a program logic exception (or misconfiguration). Even if it's only detected at runtime here.
It's the same as
ServiceNotFoundExceptionwhich even is an\InvalidArgumentException. Could eventually also be the case here.