[Messenger] Remove the default transport if no serializer service
#26649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Mar 23, 2018
Contributor
|
Might be a silly question, but why add it in the first place? Why not only add it if the serializer isn't available? |
Member
|
@iltar Good question, AFAIK we use that approach in general. I guess having as much services as possible declared in xml is good for discoverability |
nicolas-grekas
approved these changes
Mar 26, 2018
ogizanagi
approved these changes
Mar 26, 2018
sroze
added a commit
that referenced
this pull request
Mar 26, 2018
…` service (sroze) This PR was merged into the 4.1-dev branch. Discussion ---------- [Messenger] Remove the default transport if no `serializer` service | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ø | License | MIT If the `serializer` service does not exist, we remove the default transport services as they rely on it. Commits ------- 2bcf93d Remove the default transport if no serializer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
serializerservice does not exist, we remove the default transport services as they rely on it.