Make deprecation notices less verbose #26225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonbot
added
Status: Needs Review
Status: Reviewed
and removed
Status: Needs Review
labels
nicolas-grekas
approved these changes
Feb 19, 2018
fabpot
force-pushed
the
deprecation-simplification
branch
2 times, most recently
from
e898d7b to
a80e617
Compare
fabpot
force-pushed
the
deprecation-simplification
branch
from
a80e617 to
0c6ec3f
Compare
dunglas
approved these changes
Feb 19, 2018
ro0NL
approved these changes
Feb 19, 2018
Contributor
ro0NL
left a comment
ro0NL
left a comment
There was a problem hiding this comment.
there some small inconsistencies here and there formatting the alternative.
Mostly <...>, use .. instead vs. <...>. Use ... instead.
not sure we care.. cant really tell what the majority uses.
Simperfit
approved these changes
Feb 19, 2018
ogizanagi
approved these changes
Feb 19, 2018
fabpot
added a commit
that referenced
this pull request
Feb 19, 2018
This PR was merged into the 4.1-dev branch. Discussion ---------- Make deprecation notices less verbose | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a I think there is no need to say that deprecated features will be removed in the next major version. That makes messages more verbose for no real reasons. Commits ------- 0c6ec3f made deprecation notices less verbose
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is no need to say that deprecated features will be removed in the next major version. That makes messages more verbose for no real reasons.