[DoctrineBridge] Add support for datetime immutable types in doctrine type guesser #26073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvasseur
changed the title
jvasseur
force-pushed
the
immutable-guess
branch
from
75fc445 to
8c94fef
Compare
vudaltsov
approved these changes
Feb 7, 2018
nicolas-grekas
approved these changes
Feb 11, 2018
Member
|
Any doc PR to open? |
Contributor
Author
|
AFAIK the guesses made are not documented so I don't think this needs any changes in the documentation. |
fabpot
approved these changes
Feb 12, 2018
Member
|
Thank you @jvasseur. |
fabpot
added a commit
that referenced
this pull request
Feb 12, 2018
…pes in doctrine type guesser (jvasseur) This PR was merged into the 4.1-dev branch. Discussion ---------- [DoctrineBridge] Add support for datetime immutable types in doctrine type guesser | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Add support for datetime immutable types in doctrine type guesser now that we support `DateTimeImmutable` input in the form component. Commits ------- 8c94fef Add support for immutable types in doctrine type guesser
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for datetime immutable types in doctrine type guesser now that we support
DateTimeImmutableinput in the form component.