Copied NO language files to the new NB locale #25812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
AppVeyor build failure looks unrelated. |
andrerom
approved these changes
Jan 16, 2018
Member
Author
|
The HHVM job on Travis hangs, but the others are green. I doubt that I have introduced changes that break the HHVM build. |
fabpot
approved these changes
Jan 17, 2018
Member
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Jan 17, 2018
This PR was merged into the 2.7 branch. Discussion ---------- Copied NO language files to the new NB locale | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25792 | License | MIT | Doc PR | N/A This PR copies all `NO` language files to a new locale `NB`. It also adds unit tests to ensure that `NB` and `NO` will always contain the same translations. This way, we allow application developers to either use the generic `NO` language code or the more precise `NB` (e.g. if they need to distinguish between the `NB` and `NN` variants of the Norwegian language). For further details, please have a look at the discussion in #25792. Commits ------- aee9b1e Copied NO language files to the new NB locale.
This was referenced Jan 29, 2018
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR copies all
NOlanguage files to a new localeNB. It also adds unit tests to ensure thatNBandNOwill always contain the same translations. This way, we allow application developers to either use the genericNOlanguage code or the more preciseNB(e.g. if they need to distinguish between theNBandNNvariants of the Norwegian language).For further details, please have a look at the discussion in #25792.