Fixed Request::__toString ignoring cookies #25799
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Toflar
force-pushed
the
fix-request-tostring
branch
from
d2facb2 to
8d1ddf5
Compare
phansys
suggested changes
Jan 15, 2018
| $cookies[] = $k.'='.$v; | ||
| } | ||
|
|
||
| if (0 !== count($cookies)) { |
Contributor
There was a problem hiding this comment.
Please, use !empty() instead.
Contributor
Author
There was a problem hiding this comment.
Ah, I like type safety but fixed :-)
stof
approved these changes
Jan 15, 2018
phansys
approved these changes
Jan 15, 2018
dunglas
approved these changes
Jan 15, 2018
Member
|
Thank you @Toflar. |
fabpot
added a commit
that referenced
this pull request
Jan 16, 2018
This PR was squashed before being merged into the 2.7 branch (closes #25799). Discussion ---------- Fixed Request::__toString ignoring cookies | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | `Request::__toString()` ignored cookie values which caused me some headaches during a debugging session 😄 Commits ------- 0f79d09 Fixed Request::__toString ignoring cookies
This was referenced Jan 29, 2018
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request::__toString()ignored cookie values which caused me some headaches during a debugging session 😄