Skip to content

Conversation

@webmastard
Copy link

@webmastard webmastard commented Dec 14, 2017

Q A
Branch? 3.4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets #25496
License MIT
Doc PR

@xabbuh
Copy link
Member

xabbuh commented Dec 14, 2017

I am 👎 here. To me this is not a bug fix. By the way, we merged something like this with #25295 as a new feature for Symfony 4.1.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Dec 14, 2017
@chalasr
Copy link
Member

chalasr commented Dec 14, 2017

Same as @xabbuh

@webmastard
Copy link
Author

Sorry, I have not seen #25295 before.
I think it's a bug because we can use constants in yaml file since 3.2 but we can't use it in translation files.

@chalasr
Copy link
Member

chalasr commented Dec 14, 2017

It never worked, it's just unsupported. Not a bug but a missing feature really, which we would have preferred to add when introducing the constant, sadly nobody thought about it before.

@webmastard webmastard changed the title Add support for constants in yaml translation files [Transalation] Add support for constants in yaml translation files Dec 14, 2017
@webmastard webmastard changed the title [Transalation] Add support for constants in yaml translation files [Translation] Add support for constants in yaml translation files Dec 14, 2017
@fabpot
Copy link
Member

fabpot commented Dec 14, 2017

Closing for the reasons explained by @xabbuh and @chalasr

@fabpot fabpot closed this Dec 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants