[DI] turn $private to protected in dumped container, to make cache:clear BC #25268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
di-protected-privates
branch
from
e87c138 to
4cfc753
Compare
dunglas
approved these changes
Dec 2, 2017
chalasr
approved these changes
Dec 2, 2017
fabpot
requested changes
Dec 2, 2017
| private \$parameters; | ||
| private \$targetDirs = array(); | ||
| private \$privates = array(); | ||
| protected \$privates = array(); |
Member
There was a problem hiding this comment.
A small comment should be added to explain why this specific one is not private.
nicolas-grekas
force-pushed
the
di-protected-privates
branch
from
4cfc753 to
4e493e6
Compare
nicolas-grekas
changed the title
nicolas-grekas
force-pushed
the
di-protected-privates
branch
from
4e493e6 to
c98d967
Compare
Member
Author
|
Comment added. Status: needs review |
Simperfit
approved these changes
Dec 3, 2017
fabpot
approved these changes
Dec 4, 2017
stof
approved these changes
Dec 4, 2017
Member
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Dec 4, 2017
…ke cache:clear BC (nicolas-grekas) This PR was merged into the 4.0 branch. Discussion ---------- [DI] turn $private to protected in dumped container, to make cache:clear BC | Q | A | ------------- | --- | Branch? | 4.0 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Turning this property to protected changes nothing to its visibility in practice as the class is final anyway, but when migrating to SF4.0 from 3.4, the `cache:clear` command chokes with "Compile Error: Access level to srcDevDebugProjectContainer::$privates must be protected". Let's make it protected to remove this WTF. Commits ------- c98d967 [DI] turn $private to protected in dumped container, to make cache:clear BC
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turning this property to protected changes nothing to its visibility in practice as the class is final anyway,
but when migrating to SF4.0 from 3.4, the
cache:clearcommand chokes with "Compile Error: Access level to srcDevDebugProjectContainer::$privates must be protected".Let's make it protected to remove this WTF.