[SecurityBundle] Don't trigger auto-picking notice if provider is set per listener #25045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
chalasr
commented
Nov 20, 2017
chalasr
commented
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #24980 |
| License | MIT |
| Doc PR | n/a |
nicolas-grekas
approved these changes
Nov 20, 2017
ogizanagi
approved these changes
Nov 20, 2017
Member
|
I would add a test case with a config like the one provided in the linked issue to prevent regressions. |
Simperfit
approved these changes
Nov 20, 2017
chalasr
force-pushed
the
provider-guessing-deprec
branch
from
792f258 to
19e891a
Compare
xabbuh
approved these changes
Nov 20, 2017
Member
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 20, 2017
…ider is set per listener (chalasr) This PR was merged into the 3.4 branch. Discussion ---------- [SecurityBundle] Don't trigger auto-picking notice if provider is set per listener | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24980 | License | MIT | Doc PR | n/a Commits ------- 19e891a [SecurityBundle] Don't trigger auto-picking notice if provider is set per listener
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.